Fix missing indentation on targeted .method-detail elements #1435
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkibui
requested a deployment
to
fork-preview-protection
GitHub Actions
Waiting
|
If we use this approach, method entries aren't aligned: 
How about this? diff --git a/lib/rdoc/generator/template/darkfish/css/rdoc.css b/lib/rdoc/generator/template/darkfish/css/rdoc.css
index c84a604c..456d2a03 100644
--- a/lib/rdoc/generator/template/darkfish/css/rdoc.css
+++ b/lib/rdoc/generator/template/darkfish/css/rdoc.css
@@ -580,8 +580,9 @@ main .method-detail {
}
main .method-detail:target {
- margin-left: -10px;
- border-left: 10px solid var(--border-color);
+ margin-left: -15px;
+ border-left: 5px solid var(--border-color);
+ padding-left: 10px;
}
main .method-header {
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the spacing of highlighted method details in generated RDoc pages.
When a method anchor (for example, #method-i-force) is targeted, a left border is applied to the
.method-detailelement. Previously the border caused the inner content of the selected element to touch the left border, reducing readability.This change adds a small left padding to the targeted element to maintain consistent spacing between the border and its contents.